Page MenuHomePhabricator

[llvm-objdump] - Do not include reserved undefined symbol in -t output.
ClosedPublic

Authored by grimar on Dec 25 2018, 3:11 AM.

Details

Summary

This is https://bugs.llvm.org/show_bug.cgi?id=26892,

GNU objdump hides the special symbol entry:

SYMBOL TABLE:
000000000000a7e0 l     F .text	00000000000003f9 bi_copymodules

while llvm-objdump does not:

SYMBOL TABLE:
0000000000000000         *UND*		 00000000 
000000000000a7e0 l     F .text		 000003f9 bi_copymodules

Patch makes the behavior of the llvm-objdump to be consistent with the GNU objdump.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Dec 25 2018, 3:11 AM
jhenderson accepted this revision.Jan 2 2019, 4:43 AM

LGTM, with a couple of nits.

tools/llvm-objdump/llvm-objdump.cpp
1977 ↗(On Diff #179491)

dumping ELF -> dumping an ELF

1978 ↗(On Diff #179491)

output to be -> the output

This revision is now accepted and ready to land.Jan 2 2019, 4:43 AM

Thanks, James!

This revision was automatically updated to reflect the committed changes.