Page MenuHomePhabricator

Use reference only for DW_FORM_ref*
AbandonedPublic

Authored by jankratochvil on Dec 24 2018, 4:47 PM.

Details

Reviewers
clayborg
aprantl
Summary

D53530 could interpret DW_AT_count in DW_FORM_data1 as a DIE reference as it did not verify its form. Verify that reference really uses only DW_FORM_ref* forms as it could otherwise accidentally follow a constant number as DIE offset. That fixes a regression as described there.
That DW_FORM_ref_sig8 comment should be updated by D54670 after it gets approved.

Diff Detail

Repository
rLLDB LLDB