Page MenuHomePhabricator

[gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers
ClosedPublic

Authored by thakis on Dec 20 2018, 7:10 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Dec 20 2018, 7:10 PM
phosek added inline comments.Dec 21 2018, 2:42 PM
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
6 ↗(On Diff #179234)

Why not just inline this? This variable doesn't seem to be used from anywhere else?

thakis marked 2 inline comments as done.Dec 21 2018, 7:41 PM
thakis added inline comments.
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
6 ↗(On Diff #179234)

Good question. No good reason, done.

thakis marked an inline comment as done.
phosek accepted this revision.Dec 21 2018, 7:50 PM

LGTM

This revision is now accepted and ready to land.Dec 21 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.