Page MenuHomePhabricator
Differential D55981

[gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers
ClosedPublic
Actions

Authored by • thakis on Dec 20 2018, 7:10 PM.

Details

Reviewers
phosek
Commits
rG6399c5a3ba72: [gn build] Add build files for clang, clang-offload-bundler, and…
rL349991: [gn build] Add build files for clang, clang-offload-bundler, and…
Summary

With this, the GN build can build clang!

Diff Detail

Repository
rL LLVM

Event Timeline

• thakis created this revision.Dec 20 2018, 7:10 PM
Herald added a subscriber: jfb. · View Herald TranscriptDec 20 2018, 7:10 PM
• thakis added a parent revision: D55980: [gn build] Add build file for clang/lib/FrontendTool.Dec 20 2018, 7:10 PM
• thakis added a child revision: D55984: [gn build] Embed __TEXT __info_plist section into clang binary on macOS.Dec 20 2018, 7:38 PM
phosek added inline comments.Dec 21 2018, 2:42 PM
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
6 ↗(On Diff #179234)

Why not just inline this? This variable doesn't seem to be used from anywhere else?

• thakis marked 2 inline comments as done.Dec 21 2018, 7:41 PM
• thakis added inline comments.
llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
6 ↗(On Diff #179234)

Good question. No good reason, done.

• thakis updated this revision to Diff 179404.Dec 21 2018, 7:41 PM
• thakis marked an inline comment as done.
phosek accepted this revision.Dec 21 2018, 7:50 PM

LGTM

This revision is now accepted and ready to land.Dec 21 2018, 7:50 PM
Closed by commit rL349991: [gn build] Add build files for clang, clang-offload-bundler, and… (authored by nico). · Explain WhyDec 21 2018, 7:53 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 21 2018, 7:53 PM

Revision Contents
Changeset List

PathSize
llvm/
trunk/
utils/
gn/
secondary/
21 lines
clang/
lib/
Headers/
163 lines
tools/
clang-offload-bundler/
13 lines
driver/
72 lines

Diff 179407

View Options

llvm/trunk/utils/gn/secondary/BUILD.gn

Loading...
View Options

llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn

Loading...
View Options

llvm/trunk/utils/gn/secondary/clang/tools/clang-offload-bundler/BUILD.gn

Loading...
View Options

llvm/trunk/utils/gn/secondary/clang/tools/driver/BUILD.gn

Loading...