This is an archive of the discontinued LLVM Phabricator instance.

[Polly] Put the parallel context into the function entry block
ClosedPublic

Authored by jdoerfert on Oct 2 2014, 10:08 AM.

Diff Detail

Event Timeline

jdoerfert updated this revision to Diff 14333.Oct 2 2014, 10:08 AM
jdoerfert retitled this revision from to [Polly] Put the parallel context into the function entry block.
jdoerfert updated this object.
jdoerfert added subscribers: Restricted Project, Unknown Object (MLST).
grosser edited edge metadata.Oct 2 2014, 10:45 AM

No test case changes?

Otherwise LGTM

lib/CodeGen/LoopGenerators.cpp
296

I don't think this XXX is even needed. AFAIK clang will always allocate all stack space in the entry block.

dpeixott accepted this revision.Oct 2 2014, 10:51 AM
dpeixott edited edge metadata.

Needs test case. Otherwise LGTM.

lib/CodeGen/LoopGenerators.cpp
177

Use cast<> instead of dyn_cast<> when you don't check for null return result.

302

Use cast<> instead of dyn_cast<>

This revision is now accepted and ready to land.Oct 2 2014, 10:51 AM
jdoerfert updated this revision to Diff 14388.Oct 3 2014, 10:20 AM
jdoerfert edited edge metadata.

Added test and use DataLayout for best results

jdoerfert closed this revision.Oct 3 2014, 12:22 PM
jdoerfert updated this revision to Diff 14395.

Closed by commit rL219005 (authored by @jdoerfert).