[AST] Add accessSpecs() iterator range for CXXRecordDecl

[m4tx]

Summary

Adds an iterator that allows to loop over C++ class/union/struct access specifier declarations.

[riccibruno]

Do you really have to add an iterator for this particular thing ?
Why not just use specific_decl_iterator<AccessSpecDecl> in your clang-tidy checker ?

[m4tx]

In D55790#1333627, @riccibruno wrote:

Do you really have to add an iterator for this particular thing ?
Why not just use specific_decl_iterator<AccessSpecDecl> in your clang-tidy checker ?

I don't need to - if this is the preferred way to accomplish this, I'm more than happy to modify the revisions. I just saw other range methods that are only used once (e.g. CXXRecordDecl::friends()).

[aaron.ballman]

In D55790#1333664, @m4tx wrote:

In D55790#1333627, @riccibruno wrote:

Do you really have to add an iterator for this particular thing ?
Why not just use specific_decl_iterator<AccessSpecDecl> in your clang-tidy checker ?

I don't need to - if this is the preferred way to accomplish this, I'm more than happy to modify the revisions. I just saw other range methods that are only used once (e.g. CXXRecordDecl::friends()).

I think this has utility because it exposes a range accessor, but it's up to you which way you'd like to go. I left some comments in case you decide to pick this patch back up again.

include/clang/AST/DeclCXX.h

855

I'd prefer access_spec to accessspec (here and elsewhere).

include/clang/AST/DeclCXX.h

     return vbases_begin() + data().NumVBases;
   }
 
+  /// Iterator access to member access specifiers.
+  using accessspec_iterator = specific_decl_iterator<AccessSpecDecl>;
+  using accessspec_range =
+      llvm::iterator_range<specific_decl_iterator<AccessSpecDecl>>;
+
+  accessspec_range accessSpecs() const {
+    return accessspec_range(accessspec_begin(), accessspec_end());
+  }
+  accessspec_iterator accessspec_begin() const {
+    return accessspec_iterator(decl_iterator(FirstDecl));
+  }
+
+  accessspec_iterator accessspec_end() const {
+    return accessspec_iterator(decl_iterator());
+  }
+
   /// Determine whether this class has any dependent base classes which
   /// are not the current instantiation.
   bool hasAnyDependentBases() const;