Page MenuHomePhabricator

[FileCheck] Annotate input dump (final tweaks)
ClosedPublic

Authored by jdenny on Dec 15 2018, 5:52 AM.

Details

Summary

Apply final suggestions from probinson for this patch series plus a
few more tweaks:

  • Improve various docs, for MatchType in particular.
  • Rename some members of MatchType. The main problem was that the term "final match" became a misnomer when CHECK-COUNT-<N> was created.
  • Split InputStartLine, etc. declarations into multiple lines.

This patch doesn't necessarily require a review, but I wanted to put it in phabricator for safe keeping while waiting for D53899 to be accepted.

Diff Detail

Event Timeline

jdenny created this revision.Dec 15 2018, 5:52 AM
probinson accepted this revision.Dec 17 2018, 8:16 AM

Much better, thanks! LGTM

This revision is now accepted and ready to land.Dec 17 2018, 8:16 AM
This revision was automatically updated to reflect the committed changes.