Page MenuHomePhabricator

[AArch64][libunwind] Unwinding support for return address signing
ClosedPublic

Authored by LukeCheeseman on Dec 14 2018, 3:02 AM.

Details

Summary
  • Follow up to https://reviews.llvm.org/rL342895
  • gcc would not build libunwind with the earlier patch as the autia1716 instruction wasn't allowed to be assembled for pre armv8.3a targets
  • The autia1716 instruction lives in the hint space encodings so is a valid instruction for all armv8a targets
  • To work around this I have swapped out the autia1716 instruction for the hint instruction

Diff Detail

Repository
rL LLVM

Event Timeline

LukeCheeseman created this revision.Dec 14 2018, 3:02 AM
olista01 accepted this revision.Dec 14 2018, 3:25 AM

LGTM with one nit.

src/Registers.hpp
1841 ↗(On Diff #178212)

Whitespace change.

This revision is now accepted and ready to land.Dec 14 2018, 3:25 AM
This revision was automatically updated to reflect the committed changes.