This is an archive of the discontinued LLVM Phabricator instance.

Add FMF management to common fp intrinsics in GlobalIsel

Authored by mcberg2017 on Dec 13 2018, 1:01 PM.



This the initial code change to facilitate managing FMF flags from Instructions to MI wrt Intrinsics in Global Isel. Eventually the GlobalObserver interface will be added as well, where FMF additions can be tracked for the builder and CSE.

Diff Detail


Event Timeline

mcberg2017 created this revision.Dec 13 2018, 1:01 PM
mcberg2017 retitled this revision from Add FMF management to common fp intrinsics to Add FMF management to common fp intrinsics in GlobalIsel.Dec 13 2018, 1:02 PM

As requested, add one more component for copy ir flags in to this review

bogner accepted this revision.Dec 17 2018, 7:33 PM

One minor style nit, but this LGTM.

950 ↗(On Diff #178406)

I think FMA is a more normal name here, since it's an acronym.

This revision is now accepted and ready to land.Dec 17 2018, 7:33 PM

Minor nit about using -> on MachineInstr builders directly.

888 ↗(On Diff #178406)

Conversion to MachineInstr unnecessary.
PowMI->copyIRFlags.. should be sufficient.

Updated for posterity with the post review changes...

This revision was automatically updated to reflect the committed changes.