This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Fix defines define on Windows
ClosedPublic

Authored by smeenai on Dec 12 2018, 2:03 PM.

Details

Summary

On Windows, we won't go into the host_os != "win" block, so defines
won't have been defined, and we'll run into an undefined identifier
error when we try to later append to it. Unconditionally define it at
the start and append to it everywhere else.

Diff Detail

Event Timeline

smeenai created this revision.Dec 12 2018, 2:03 PM
thakis accepted this revision.Dec 12 2018, 3:50 PM

Thanks!

This revision is now accepted and ready to land.Dec 12 2018, 3:50 PM
This revision was automatically updated to reflect the committed changes.