This is an archive of the discontinued LLVM Phabricator instance.

[globalisel] Rename GISelChangeObserver's erasedInstr() to erasingInstr() and related nits. NFC
ClosedPublic

Authored by dsanders on Dec 12 2018, 12:47 PM.

Details

Summary

There's little of interest that can be done to an already-erased instruction.
You can't inspect it, write it to a debug log, etc. It ought to be notification
that we're about to erase it. Rename the function to clarify the timing of the
event and reflect current usage.

Also fixed one case where we were trying to print an erased instruction.

Diff Detail

Event Timeline

dsanders created this revision.Dec 12 2018, 12:47 PM

Thanks. LGTM.

This revision is now accepted and ready to land.Dec 12 2018, 12:56 PM
dsanders retitled this revision from Rename GISelChangeObserver's erasedInstr() to erasingInstr() and related nits. NFC to [globalisel] Rename GISelChangeObserver's erasedInstr() to erasingInstr() and related nits. NFC.Dec 12 2018, 1:34 PM
This revision was automatically updated to reflect the committed changes.