This is an archive of the discontinued LLVM Phabricator instance.

Differential D55591

[gn build] Add build files for DebugInfo/{DWARF,PDB}, Option, ToolDrivers/llvm-lib, and WindowsManifest
ClosedPublic

Authored by thakis on Dec 11 2018, 6:00 PM.

Details

Reviewers
phosek
Commits
rGf237836fd150: [gn build] Add build files for DebugInfo/{DWARF,PDB}, Option, ToolDrivers/llvm…
rL348908: [gn build] Add build files for DebugInfo/{DWARF,PDB}, Option, ToolDrivers/llvm…
Summary

These are the remaining build files needed for building lld. Mostly boring.

The diff in targets.gni is due to me running gn format on all gn(i) files.

llvm_enable_dia_sdk is in a gni file because I'm going to have to read it when writing the lit invocations for check-llvm and check-lld. I've never had the DIA sdk installed locally so I never tested building with it enabled -- it probably doesn't Just Work and needs some path to diaguids.lib. We can finish that once somebody needs it.

Diff Detail

Event Timeline

thakis created this revision.Dec 11 2018, 6:00 PM
Herald added subscribers: JDevlieghere, hiraditya. · View Herald TranscriptDec 11 2018, 6:00 PM
phosek accepted this revision.Dec 11 2018, 6:34 PM

LGTM

This revision is now accepted and ready to land.Dec 11 2018, 6:34 PM
Closed by commit rL348908: [gn build] Add build files for DebugInfo/{DWARF,PDB}, Option, ToolDrivers/llvm… (authored by nico). · Explain WhyDec 11 2018, 7:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
utils/
gn/
secondary/
llvm/
lib/
DebugInfo/
DWARF/
38 lines
PDB/
118 lines
4 lines
Option/
12 lines
Target/
4 lines
ToolDrivers/
llvm-lib/
20 lines
WindowsManifest/
11 lines

Diff 177807

llvm/utils/gn/secondary/llvm/lib/DebugInfo/DWARF/BUILD.gn

  • This file was added.
static_library("DWARF") {
output_name = "LLVMDebugInfoDWARF"
deps = [
"//llvm/lib/BinaryFormat",
"//llvm/lib/MC",
"//llvm/lib/Object",
"//llvm/lib/Support",
]
sources = [
"DWARFAbbreviationDeclaration.cpp",
"DWARFAcceleratorTable.cpp",
"DWARFAddressRange.cpp",
"DWARFCompileUnit.cpp",
"DWARFContext.cpp",
"DWARFDataExtractor.cpp",
"DWARFDebugAbbrev.cpp",
"DWARFDebugAddr.cpp",
"DWARFDebugArangeSet.cpp",
"DWARFDebugAranges.cpp",
"DWARFDebugFrame.cpp",
"DWARFDebugInfoEntry.cpp",
"DWARFDebugLine.cpp",
"DWARFDebugLoc.cpp",
"DWARFDebugMacro.cpp",
"DWARFDebugPubTable.cpp",
"DWARFDebugRangeList.cpp",
"DWARFDebugRnglists.cpp",
"DWARFDie.cpp",
"DWARFExpression.cpp",
"DWARFFormValue.cpp",
"DWARFGdbIndex.cpp",
"DWARFListTable.cpp",
"DWARFTypeUnit.cpp",
"DWARFUnit.cpp",
"DWARFUnitIndex.cpp",
"DWARFVerifier.cpp",
]
}

llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

  • This file was added.
import("//llvm/lib/DebugInfo/PDB/enable_dia.gni")
static_library("PDB") {
output_name = "LLVMDebugInfoPDB"
deps = [
"//llvm/include/llvm/Config:config",
"//llvm/lib/DebugInfo/CodeView",
"//llvm/lib/DebugInfo/MSF",
"//llvm/lib/Object",
"//llvm/lib/Support",
]
sources = [
"GenericError.cpp",
"IPDBSourceFile.cpp",
"Native/DbiModuleDescriptor.cpp",
"Native/DbiModuleDescriptorBuilder.cpp",
"Native/DbiModuleList.cpp",
"Native/DbiStream.cpp",
"Native/DbiStreamBuilder.cpp",
"Native/EnumTables.cpp",
"Native/GSIStreamBuilder.cpp",
"Native/GlobalsStream.cpp",
"Native/Hash.cpp",
"Native/HashTable.cpp",
"Native/InfoStream.cpp",
"Native/InfoStreamBuilder.cpp",
"Native/ModuleDebugStream.cpp",
"Native/NamedStreamMap.cpp",
"Native/NativeCompilandSymbol.cpp",
"Native/NativeEnumGlobals.cpp",
"Native/NativeEnumModules.cpp",
"Native/NativeEnumTypes.cpp",
"Native/NativeExeSymbol.cpp",
"Native/NativeRawSymbol.cpp",
"Native/NativeSession.cpp",
"Native/NativeSymbolEnumerator.cpp",
"Native/NativeTypeArray.cpp",
"Native/NativeTypeBuiltin.cpp",
"Native/NativeTypeEnum.cpp",
"Native/NativeTypeFunctionSig.cpp",
"Native/NativeTypePointer.cpp",
"Native/NativeTypeTypedef.cpp",
"Native/NativeTypeUDT.cpp",
"Native/NativeTypeVTShape.cpp",
"Native/PDBFile.cpp",
"Native/PDBFileBuilder.cpp",
"Native/PDBStringTable.cpp",
"Native/PDBStringTableBuilder.cpp",
"Native/PublicsStream.cpp",
"Native/RawError.cpp",
"Native/SymbolCache.cpp",
"Native/SymbolStream.cpp",
"Native/TpiHashing.cpp",
"Native/TpiStream.cpp",
"Native/TpiStreamBuilder.cpp",
"PDB.cpp",
"PDBContext.cpp",
"PDBExtras.cpp",
"PDBInterfaceAnchors.cpp",
"PDBSymDumper.cpp",
"PDBSymbol.cpp",
"PDBSymbolAnnotation.cpp",
"PDBSymbolBlock.cpp",
"PDBSymbolCompiland.cpp",
"PDBSymbolCompilandDetails.cpp",
"PDBSymbolCompilandEnv.cpp",
"PDBSymbolCustom.cpp",
"PDBSymbolData.cpp",
"PDBSymbolExe.cpp",
"PDBSymbolFunc.cpp",
"PDBSymbolFuncDebugEnd.cpp",
"PDBSymbolFuncDebugStart.cpp",
"PDBSymbolLabel.cpp",
"PDBSymbolPublicSymbol.cpp",
"PDBSymbolThunk.cpp",
"PDBSymbolTypeArray.cpp",
"PDBSymbolTypeBaseClass.cpp",
"PDBSymbolTypeBuiltin.cpp",
"PDBSymbolTypeCustom.cpp",
"PDBSymbolTypeDimension.cpp",
"PDBSymbolTypeEnum.cpp",
"PDBSymbolTypeFriend.cpp",
"PDBSymbolTypeFunctionArg.cpp",
"PDBSymbolTypeFunctionSig.cpp",
"PDBSymbolTypeManaged.cpp",
"PDBSymbolTypePointer.cpp",
"PDBSymbolTypeTypedef.cpp",
"PDBSymbolTypeUDT.cpp",
"PDBSymbolTypeVTable.cpp",
"PDBSymbolTypeVTableShape.cpp",
"PDBSymbolUnknown.cpp",
"PDBSymbolUsingNamespace.cpp",
"UDTLayout.cpp",
]
if (llvm_enable_dia_sdk) {
sources += [
"DIA/DIADataStream.cpp",
"DIA/DIAEnumDebugStreams.cpp",
"DIA/DIAEnumFrameData.cpp",
"DIA/DIAEnumInjectedSources.cpp",
"DIA/DIAEnumLineNumbers.cpp",
"DIA/DIAEnumSectionContribs.cpp",
"DIA/DIAEnumSourceFiles.cpp",
"DIA/DIAEnumSymbols.cpp",
"DIA/DIAEnumTables.cpp",
"DIA/DIAError.cpp",
"DIA/DIAFrameData.cpp",
"DIA/DIAInjectedSource.cpp",
"DIA/DIALineNumber.cpp",
"DIA/DIARawSymbol.cpp",
"DIA/DIASectionContrib.cpp",
"DIA/DIASession.cpp",
"DIA/DIASourceFile.cpp",
"DIA/DIATable.cpp",
]
# FIXME: Link against the right diaguids.lib too.
}
}

llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/enable_dia.gni

  • This file was added.
declare_args() {
# Whether to build code that requires the Microsoft DIA SDK.
llvm_enable_dia_sdk = false
}

llvm/utils/gn/secondary/llvm/lib/Option/BUILD.gn

  • This file was added.
static_library("Option") {
output_name = "LLVMOption"
deps = [
"//llvm/lib/Support",
]
sources = [
"Arg.cpp",
"ArgList.cpp",
"OptTable.cpp",
"Option.cpp",
]
}

llvm/utils/gn/secondary/llvm/lib/Target/targets.gni

declare_args() { declare_args() {
# The target archs LLVM should support. Defaults to the host arch. # The target archs LLVM should support. Defaults to the host arch.
# Set to a list, e.g. `llvm_targets_to_build = [ "X86", "ARM" ]`, # Set to a list, e.g. `llvm_targets_to_build = [ "X86", "ARM" ]`,
# or to the string "all" to get all known targets. # or to the string "all" to get all known targets.
llvm_targets_to_build = "host" llvm_targets_to_build = "host"
} }
if (llvm_targets_to_build == "host") { if (llvm_targets_to_build == "host") {
if (host_cpu == "x86" || host_cpu == "x64") { if (host_cpu == "x86" || host_cpu == "x64") {
llvm_targets_to_build = [ "X86" ] llvm_targets_to_build = [ "X86" ]
} else { } else {
assert(false, "add your host_cpu above") assert(false, "add your host_cpu above")
} }
} else if (llvm_targets_to_build == "all") { } else if (llvm_targets_to_build == "all") {
# FIXME: Port the remaining targets. # FIXME: Port the remaining targets.
llvm_targets_to_build = [ llvm_targets_to_build = [ "X86" ]
"X86",
]
} }
# Validate that llvm_targets_to_build is set to a list of valid targets, # Validate that llvm_targets_to_build is set to a list of valid targets,
# and remember which targets are built. # and remember which targets are built.
llvm_build_X86 = false llvm_build_X86 = false
foreach(target, llvm_targets_to_build) { foreach(target, llvm_targets_to_build) {
if (target == "X86") { if (target == "X86") {
llvm_build_X86 = true llvm_build_X86 = true
Show All 12 Lines

llvm/utils/gn/secondary/llvm/lib/ToolDrivers/llvm-lib/BUILD.gn

  • This file was added.
import("//llvm/utils/TableGen/tablegen.gni")
tablegen("Options") {
visibility = [ ":LibDriver" ]
args = [ "-gen-opt-parser-defs" ]
}
static_library("LibDriver") {
output_name = "LLVMLibDriver"
deps = [
":Options",
"//llvm/lib/BinaryFormat",
"//llvm/lib/Object",
"//llvm/lib/Option",
"//llvm/lib/Support",
]
sources = [
"LibDriver.cpp",
]
}

llvm/utils/gn/secondary/llvm/lib/WindowsManifest/BUILD.gn

  • This file was added.
static_library("WindowsManifest") {
output_name = "LLVMWindowsManifest"
deps = [
"//llvm/include/llvm/Config:config",
"//llvm/lib/Support",
"//llvm/utils/gn/build/libs/xml",
]
sources = [
"WindowsManifestMerger.cpp",
]
}