This is an archive of the discontinued LLVM Phabricator instance.

Differential D55537

Should not export public functions implemented in assembly when build static lib on Windows
ClosedPublic

Authored by SquallATF on Dec 10 2018, 6:05 PM.

Details

Reviewers
mstorsjo
Commits
rGa64aa485e156: Don't export assembly functions when function visibility annotations are…
rUNW348832: Don't export assembly functions when function visibility annotations are…
rL348832: Don't export assembly functions when function visibility annotations are…

Diff Detail

Event Timeline

SquallATF created this revision.Dec 10 2018, 6:05 PM
Herald added subscribers: libcxx-commits, christof. · View Herald TranscriptDec 10 2018, 6:05 PM
Harbormaster completed remote builds in B25912: Diff 177638.Dec 10 2018, 6:06 PM
mstorsjo accepted this revision.Dec 10 2018, 11:34 PM

LGTM

This revision is now accepted and ready to land.Dec 10 2018, 11:34 PM
Closed by commit rL348832: Don't export assembly functions when function visibility annotations are… (authored by mstorsjo). · Explain WhyDec 10 2018, 11:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 10 2018, 11:40 PM

Revision Contents

PathSize
src/
4 lines

Diff 177638

src/assembly.h

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Lines#define SYMBOL_IS_FUNC(name) \
.def name SEPARATOR \ .def name SEPARATOR \
.scl 2 SEPARATOR \ .scl 2 SEPARATOR \
.type 32 SEPARATOR \ .type 32 SEPARATOR \
.endef .endef
#define EXPORT_SYMBOL2(name) \ #define EXPORT_SYMBOL2(name) \
.section .drectve,"yn" SEPARATOR \ .section .drectve,"yn" SEPARATOR \
.ascii "-export:", #name, "\0" SEPARATOR \ .ascii "-export:", #name, "\0" SEPARATOR \
.text .text
#if defined(_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS)
#define EXPORT_SYMBOL(name)
#else
#define EXPORT_SYMBOL(name) EXPORT_SYMBOL2(name) #define EXPORT_SYMBOL(name) EXPORT_SYMBOL2(name)
#endif
#define HIDDEN_SYMBOL(name) #define HIDDEN_SYMBOL(name)
#define NO_EXEC_STACK_DIRECTIVE #define NO_EXEC_STACK_DIRECTIVE
#else #else
#error Unsupported target #error Unsupported target
Show All 31 Lines