This is an archive of the discontinued LLVM Phabricator instance.

[NFC][AArch64] Remove duplicate Arch list in target parser tests.
ClosedPublic

Authored by DavidSpickett on Dec 10 2018, 6:20 AM.

Reviewers

Commits

Summary

The list generated in the target parser tests is the
same as the one in the AArch64 target parser.
Use that one instead.

LGTM

This revision is now accepted and ready to land.Dec 10 2018, 6:26 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

unittests/

Support/

7 lines

Show First 20 Lines • Show All 959 Lines • ▼ Show 20 Lines	TEST(TargetParserTest, AArch64ExtensionFeatures) {

for (unsigned i = 0; i <= Extensions; i++)		for (unsigned i = 0; i <= Extensions; i++)
EXPECT_TRUE(i == 0 ? !AArch64::getExtensionFeatures(i, Features)		EXPECT_TRUE(i == 0 ? !AArch64::getExtensionFeatures(i, Features)
: AArch64::getExtensionFeatures(i, Features));		: AArch64::getExtensionFeatures(i, Features));
}		}

TEST(TargetParserTest, AArch64ArchFeatures) {		TEST(TargetParserTest, AArch64ArchFeatures) {
std::vector<StringRef> Features;		std::vector<StringRef> Features;
AArch64::ArchKind ArchKinds[] = {
#define AARCH64_ARCH(NAME, ID, CPU_ATTR, SUB_ARCH, ARCH_ATTR, ARCH_FPU, ARCH_BASE_EXT) \
AArch64::ArchKind::ID,
#include "llvm/Support/AArch64TargetParser.def"
};

for (auto AK : ArchKinds)		for (auto AK : AArch64::ArchKinds)
EXPECT_TRUE((AK == AArch64::ArchKind::INVALID)		EXPECT_TRUE((AK == AArch64::ArchKind::INVALID)
? !AArch64::getArchFeatures(AK, Features)		? !AArch64::getArchFeatures(AK, Features)
: AArch64::getArchFeatures(AK, Features));		: AArch64::getArchFeatures(AK, Features));
}		}

TEST(TargetParserTest, AArch64ArchExtFeature) {		TEST(TargetParserTest, AArch64ArchExtFeature) {
const char *ArchExt[][4] = {{"crc", "nocrc", "+crc", "-crc"},		const char *ArchExt[][4] = {{"crc", "nocrc", "+crc", "-crc"},
{"crypto", "nocrypto", "+crypto", "-crypto"},		{"crypto", "nocrypto", "+crypto", "-crypto"},
Show All 23 Lines