This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Remove SUBC handling from computeKnownBits
AbandonedPublic

Authored by craig.topper on Dec 7 2018, 4:56 PM.

Details

Summary

The code that computes the known bits wasn't taking into account the possibility of an incoming carry. So I don't think this code was valid. Certainly not the code that assumed the number of low zero bits in each input determined the low zero bits of the output.

I found this purely by inspection so I don't have a test case.

Diff Detail

Event Timeline

craig.topper created this revision.Dec 7 2018, 4:56 PM

SUBC doesn't have an incoming carry...

craig.topper abandoned this revision.Dec 7 2018, 7:15 PM

Oops. SUBE would be the one with carry in. Nevermind