This is an archive of the discontinued LLVM Phabricator instance.

Differential D55442

Update the Swift version numbers reported by objdump
ClosedPublic

Authored by mtrent on Dec 7 2018, 9:16 AM.

Details

Reviewers
pete
lhames
bob.wilson
Commits
rGf7254a698b79: Update the Swift version numbers reported by objdump
rL348632: Update the Swift version numbers reported by objdump
Summary

Add Swift 4.1, Swift 4.2, and Swift 5 version numbers to objdump's
MachODump's print_imae_info routines.

rdar://46548425

Diff Detail

Event Timeline

mtrent created this revision.Dec 7 2018, 9:16 AM
Harbormaster completed remote builds in B25839: Diff 177237.Dec 7 2018, 9:17 AM
pete accepted this revision.Dec 7 2018, 10:02 AM

LGTM

This revision is now accepted and ready to land.Dec 7 2018, 10:02 AM
bob.wilson accepted this revision.Dec 7 2018, 10:13 AM
bob.wilson added a subscriber: bob.wilson.

LGTM, too.

Closed by commit rL348632: Update the Swift version numbers reported by objdump (authored by mtrent). · Explain WhyDec 7 2018, 11:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-objdump/
8 lines

Diff 177237

tools/llvm-objdump/MachODump.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,620 Lines • ▼ Show 20 Lines else if (swift_version == 2)
outs() << " Swift 1.1"; outs() << " Swift 1.1";
else if(swift_version == 3) else if(swift_version == 3)
outs() << " Swift 2.0"; outs() << " Swift 2.0";
else if(swift_version == 4) else if(swift_version == 4)
outs() << " Swift 3.0"; outs() << " Swift 3.0";
else if(swift_version == 5) else if(swift_version == 5)
outs() << " Swift 4.0"; outs() << " Swift 4.0";
else if(swift_version == 6) else if(swift_version == 6)
outs() << " Swift 4.1"; outs() << " Swift 4.1/Swift 4.2";
else if(swift_version == 7)
outs() << " Swift 5 or later";
else else
outs() << " unknown future Swift version (" << swift_version << ")"; outs() << " unknown future Swift version (" << swift_version << ")";
} }
outs() << "\n"; outs() << "\n";
} }
static void print_image_info32(SectionRef S, struct DisassembleInfo *info) { static void print_image_info32(SectionRef S, struct DisassembleInfo *info) {
uint32_t left, offset, swift_version, p; uint32_t left, offset, swift_version, p;
Show All 34 Lines else if (swift_version == 2)
outs() << " Swift 1.1"; outs() << " Swift 1.1";
else if(swift_version == 3) else if(swift_version == 3)
outs() << " Swift 2.0"; outs() << " Swift 2.0";
else if(swift_version == 4) else if(swift_version == 4)
outs() << " Swift 3.0"; outs() << " Swift 3.0";
else if(swift_version == 5) else if(swift_version == 5)
outs() << " Swift 4.0"; outs() << " Swift 4.0";
else if(swift_version == 6) else if(swift_version == 6)
outs() << " Swift 4.1"; outs() << " Swift 4.1/Swift 4.2";
else if(swift_version == 7)
outs() << " Swift 5 or later";
else else
outs() << " unknown future Swift version (" << swift_version << ")"; outs() << " unknown future Swift version (" << swift_version << ")";
} }
outs() << "\n"; outs() << "\n";
} }
static void print_image_info(SectionRef S, struct DisassembleInfo *info) { static void print_image_info(SectionRef S, struct DisassembleInfo *info) {
uint32_t left, offset, p; uint32_t left, offset, p;
▲ Show 20 Lines • Show All 4,341 Lines • Show Last 20 Lines