The option has no tests, is not used anywhere, and is actually incorrect: it prints the line number without the reference to a file, which can be outright incorrect.
Details
Details
Diff Detail
Diff Detail
Paths
| Differential D55385
[analyzer] RetainCountChecker: remove untested, unused, incorrect option IncludeAllocationLine ClosedPublic Authored by george.karpenkov on Dec 6 2018, 2:27 PM.
Details Summary The option has no tests, is not used anywhere, and is actually incorrect: it prints the line number without the reference to a file, which can be outright incorrect.
Diff Detail Event TimelineHerald added subscribers: dkrupp, donat.nagy, Szelethus and 5 others. · View Herald TranscriptDec 6 2018, 2:27 PM This revision is now accepted and ready to land.Dec 6 2018, 2:28 PM Closed by commit rC348637: [analyzer] RetainCountChecker: remove untested, unused, incorrect option… (authored by george.karpenkov). · Explain WhyDec 7 2018, 12:25 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 177055 clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.h
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
|