This is an archive of the discontinued LLVM Phabricator instance.

[X86] Directly create ADC/SBB nodes instead of using ADD/SUB with (and SETCC_CARRY, 1)
ClosedPublic

Authored by craig.topper on Dec 5 2018, 11:34 PM.

Details

Summary

This addresses a FIXME and avoids depending on an isel pattern match I think.

I'm trying to decide if we need SETCC_CARRY. This removes one of its usages.

Diff Detail

Event Timeline

craig.topper created this revision.Dec 5 2018, 11:34 PM

This addresses a FIXME and avoids depending on an isel pattern match I think.

So the isel pattern is still required?

Remove the isel patterns.

RKSimon accepted this revision.Dec 6 2018, 1:31 PM

LGTM - thanks. If you have concerns that the isel pattern is still used anywhere, I'm fine with it staying with a suitable FIXME comment.

This revision is now accepted and ready to land.Dec 6 2018, 1:31 PM
This revision was automatically updated to reflect the committed changes.