This is an archive of the discontinued LLVM Phabricator instance.

NFC: Move VisitExpr code to dumpStmt
ClosedPublic

Authored by steveire on Dec 5 2018, 1:08 PM.

Details

Summary

The call is duplicated in the handlers of all Expr subclasses.

This change makes it easy to split statement handling out to
TextNodeDumper.

Diff Detail

Event Timeline

steveire created this revision.Dec 5 2018, 1:08 PM
aaron.ballman accepted this revision.Dec 6 2018, 5:52 AM

LGTM aside from a small nit.

lib/AST/ASTDumper.cpp
1698

const auto *

This revision is now accepted and ready to land.Dec 6 2018, 5:52 AM
This revision was automatically updated to reflect the committed changes.