This is an archive of the discontinued LLVM Phabricator instance.

Differential D55322

Mention changes to libc++ include dir lookup in release notes.
ClosedPublic

Authored by ilya-biryukov on Dec 5 2018, 6:51 AM.

Details

Reviewers
arphaman
EricWF
Commits
rG88aef52a5d27: Mention changes to libc++ include dir lookup in release notes.
rL348394: Mention changes to libc++ include dir lookup in release notes.
rC348394: Mention changes to libc++ include dir lookup in release notes.
Summary

The change itself landed as r348365, see the comment for more details.

Diff Detail

Repository
rC Clang

Event Timeline

ilya-biryukov created this revision.Dec 5 2018, 6:51 AM
Herald added a reviewer: EricWF. · View Herald TranscriptDec 5 2018, 6:51 AM
Harbormaster completed remote builds in B25725: Diff 176809.Dec 5 2018, 6:51 AM
ilya-biryukov mentioned this in D54630: Move detection of libc++ include dirs to Driver on MacOS.Dec 5 2018, 6:51 AM
arphaman accepted this revision.Dec 5 2018, 9:40 AM

LGTM.

This revision is now accepted and ready to land.Dec 5 2018, 9:40 AM
Closed by commit rC348394: Mention changes to libc++ include dir lookup in release notes. (authored by ibiryukov). · Explain WhyDec 5 2018, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
docs/
7 lines

Diff 176854

docs/ReleaseNotes.rst

Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Lines
Non-comprehensive list of changes in this release Non-comprehensive list of changes in this release
------------------------------------------------- -------------------------------------------------
- The experimental feature Pretokenized Headers (PTH) was removed in its - The experimental feature Pretokenized Headers (PTH) was removed in its
entirely from Clang. The feature did not properly work with about 1/3 of the entirely from Clang. The feature did not properly work with about 1/3 of the
possible tokens available and was unmaintained. possible tokens available and was unmaintained.
- The internals of libc++ include directory detection on MacOS have changed.
Instead of running a search based on the ``-resource-dir`` flag, the search
is now based on the path of the compiler in the filesystem. The default
behaviour should not change. However, if you override ``-resource-dir``
manually and rely on the old behaviour you will need to add appropriate
compiler flags for finding the corresponding libc++ include directory.
New Compiler Flags New Compiler Flags
------------------ ------------------
- ``-fprofile-filter-files=[regexes]`` and ``-fprofile-exclude-files=[regexes]``. - ``-fprofile-filter-files=[regexes]`` and ``-fprofile-exclude-files=[regexes]``.
Clang has now options to filter or exclude some files when Clang has now options to filter or exclude some files when
instrumenting for gcov-based profiling. instrumenting for gcov-based profiling.
See the :doc:`UsersManual` for details. See the :doc:`UsersManual` for details.
▲ Show 20 Lines • Show All 201 Lines • Show Last 20 Lines