Page MenuHomePhabricator

[FileSystem] Migrate CommandCompletions

Authored by JDevlieghere on Dec 3 2018, 3:39 PM.

Diff Detail


Event Timeline

JDevlieghere created this revision.Dec 3 2018, 3:39 PM
davide added a comment.Dec 3 2018, 3:44 PM

No objections from me, but I would appreciate if @labath can take a look.

Initialize the FS in the unit test.

labath accepted this revision.Dec 4 2018, 2:41 AM

Looks good, modulo the filesystem copy comment.

180 ↗(On Diff #176525)

This should surely be a reference, no? Making a copy of a filesystem sounds weird (and should probably be forbidden by deleting the copy constructor).

This revision is now accepted and ready to land.Dec 4 2018, 2:41 AM
JDevlieghere marked an inline comment as done.Dec 4 2018, 9:34 AM
JDevlieghere added inline comments.
180 ↗(On Diff #176525)

Correct, this is a typo but shouldn't compile. I'll include the fix when landing.

This revision was automatically updated to reflect the committed changes.