This is an archive of the discontinued LLVM Phabricator instance.

Differential D55201

Python2/3 compat - repr
ClosedPublic

Authored by serge-sans-paille on Dec 3 2018, 2:45 AM.

Details

Reviewers
joerg
michaelplatings
Commits
rGf606a5ae6258: Portable Python script across Python version
rC348182: Portable Python script across Python version
rL348182: Portable Python script across Python version

Diff Detail

Event Timeline

serge-sans-paille created this revision.Dec 3 2018, 2:45 AM
michaelplatings accepted this revision.Dec 3 2018, 8:48 AM

LGTM

This revision is now accepted and ready to land.Dec 3 2018, 8:48 AM
Closed by commit rL348182: Portable Python script across Python version (authored by serge_sans_paille). · Explain WhyDec 3 2018, 12:16 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 3 2018, 12:16 PM

Revision Contents

PathSize
tools/
scan-view/
share/
2 lines

Diff 176342

tools/scan-view/share/ScanView.py

Context not available.
"""%(r.getName(),display,r.getName(),options)) """%(r.getName(),display,r.getName(),options))
reporterSelections = '\n'.join(reporterSelections) reporterSelections = '\n'.join(reporterSelections)
reporterOptionsDivs = '\n'.join(reporterOptions) reporterOptionsDivs = '\n'.join(reporterOptions)
reportersArray = '[%s]'%(','.join([`r.getName()` for r in self.server.reporters])) reportersArray = '[%s]'%(','.join([repr(r.getName()) for r in self.server.reporters]))
if c.files: if c.files:
fieldSize = min(5, len(c.files)) fieldSize = min(5, len(c.files))
Context not available.