Python2/3 compat - urllib

[joerg]

docs/tools/dump_ast_matchers.py

11

Missing follow-up change in the rest of the file.

[serge-sans-paille]

Thanks for spotting that, I messed up during the (huge) git add -p session :p

[michaelplatings]

tools/scan-view/bin/scan-view

15 ↗

(On Diff #176574)

Python 3's urlopen is equivalent to urllib2.urlopen not urllib.urlopen so I recommend importing from urllib2 instead.

[michaelplatings]

tools/scan-view/bin/scan-view

15 ↗

(On Diff #176574)

This should be the same as dump_ast_matchers.py i.e.:

try:
    from urllib.request import urlopen
except ImportError:
    from urllib2 import urlopen

[michaelplatings]

tools/scan-view/bin/scan-view

15 ↗

(On Diff #176574)

This still isn't done.

[serge-sans-paille]

Sorry for the noise :-/

[michaelplatings]

LGTM

docs/tools/dump_ast_matchers.py

 
 import collections
 import re
-import urllib2
+try:
+    from urllib.request import urlopen
+except ImportError:
+    from urllib2 import urlopen
 
 MATCHERS_FILE = '../../include/clang/ASTMatchers/ASTMatchers.h'
 

docs/tools/dump_format_style.py

 import collections
 import os
 import re
-import urllib2
 
 CLANG_DIR = os.path.join(os.path.dirname(__file__), '../..')
 FORMAT_STYLE_FILE = os.path.join(CLANG_DIR, 'include/clang/Format/Format.h')

tools/scan-view/share/ScanView.py

 from __future__ import print_function
 import os
 import sys
-import urllib, urlparse
+try:
+    from urllib import parse as urlparse, quote as urlquote, unquote as urlunquote
+except ImportError:
+    from urllib.parse import parse as urlparse, quote as urlquote, unquote as urlunquote
+
 import posixpath
 
 from io import StringIO

             value = ''
         else:
             name, value = chunk.split('=', 1)
-        name = urllib.unquote(name.replace('+', ' '))
-        value = urllib.unquote(value.replace('+', ' '))
+        name = urlunquote(name.replace('+', ' '))
+        value = urlunquote(value.replace('+', ' '))
         item = fields.get(name)
         if item is None:
             fields[name] = [value]

             fields = {}
         self.fields = fields
 
-        o = urlparse.urlparse(self.path)
+        o = urlparse(self.path)
         self.fields = parse_query(o.query, fields)
-        path = posixpath.normpath(urllib.unquote(o.path))
+        path = posixpath.normpath(urlunquote(o.path))
 
         # Split the components and strip the root prefix.
         components = path.split('/')[1:]