This is an archive of the discontinued LLVM Phabricator instance.

Differential D55198

Python 2/3 compat - type destructuring
ClosedPublic

Authored by serge-sans-paille on Dec 3 2018, 2:43 AM.

Details

Reviewers
joerg
michaelplatings
Commits
rG75394aa5bb0c: Portable Python script across Python version
rC348129: Portable Python script across Python version
rL348129: Portable Python script across Python version
Summary

type destructuring in function parameters

Diff Detail

Event Timeline

serge-sans-paille created this revision.Dec 3 2018, 2:43 AM
serge-sans-paille retitled this revision from Python 2/3 compat to Python 2/3 compat - type destructuring.Dec 3 2018, 2:52 AM
joerg accepted this revision.Dec 3 2018, 4:14 AM

LGTM

This revision is now accepted and ready to land.Dec 3 2018, 4:14 AM
Closed by commit rL348129: Portable Python script across Python version (authored by serge_sans_paille). · Explain WhyDec 3 2018, 4:44 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 3 2018, 4:44 AM

Revision Contents

PathSize
utils/
ABITest/
3 lines
3 lines

Diff 176339

utils/ABITest/Enumeration.py

Context not available.
def base(line): def base(line):
return line*(line+1)//2 return line*(line+1)//2
def pairToN((x,y)): def pairToN(pair):
x,y = pair
line,index = x+y,y line,index = x+y,y
return base(line)+index return base(line)+index
Context not available.

utils/ABITest/TypeGen.py

Context not available.
' '.join(map(getField, self.fields))) ' '.join(map(getField, self.fields)))
def getTypedefDef(self, name, printer): def getTypedefDef(self, name, printer):
def getField((i, t)): def getField(it):
i, t = it
if t.isBitField(): if t.isBitField():
if t.isPaddingBitField(): if t.isPaddingBitField():
return '%s : 0;'%(printer.getTypeName(t),) return '%s : 0;'%(printer.getTypeName(t),)
Context not available.