Page MenuHomePhabricator

[gn build] Process files in llvm/include/Config and that to add a build file for llvm/lib/Target

Authored by thakis on Dec 2 2018, 4:50 PM.



Tweak to also handle variable references looking @FOO@ (matching CMake's configure_file() function), and make it replace '\' 'n' in values with a newline literal since there's no good portable way of passing a real newline literal on a command line.

Use that to process all the files in llvm/include/Config and add llvm/lib/Target, which (indirectly, through llvm-c/Target.h) includes them.

Diff Detail


Event Timeline

thakis created this revision.Dec 2 2018, 4:50 PM
phosek accepted this revision.Dec 5 2018, 11:53 PM


368 ↗(On Diff #176307)

Can you please also provide an error message?

398 ↗(On Diff #176307)

Can you put spaces between each target to visually separate them?

This revision is now accepted and ready to land.Dec 5 2018, 11:53 PM
thakis marked 2 inline comments as done.Dec 6 2018, 9:45 AM
This revision was automatically updated to reflect the committed changes.