Page MenuHomePhabricator
Differential D55151

[gcov/Darwin] Ensure external symbols are exported when using an export list
ClosedPublic
Actions

Authored by vsk on Nov 30 2018, 4:16 PM.

Details

Reviewers
ributzka
steven_wu
calixte
marco-c
Commits
rG6b062cd694d4: [gcov/Darwin] Ensure external symbols are exported when using an export list
rCRT348187: [gcov/Darwin] Ensure external symbols are exported when using an export list
rC348187: [gcov/Darwin] Ensure external symbols are exported when using an export list
rL348187: [gcov/Darwin] Ensure external symbols are exported when using an export list
Summary

Make sure that symbols needed to implement runtime support for gcov are
exported when using an export list on Darwin.

Without the clang driver exporting these symbols, the linker hides them,
resulting in tapi verification failures.

rdar://45944768

Diff Detail

Repository
rL LLVM

Event Timeline

vsk created this revision.Nov 30 2018, 4:16 PM
ributzka added inline comments.Nov 30 2018, 5:06 PM
clang/lib/Driver/ToolChains/Darwin.cpp
1037 ↗(On Diff #176217)

Are the symbols mutually exclusive?

vsk marked an inline comment as done.Nov 30 2018, 5:07 PM
vsk added inline comments.
clang/lib/Driver/ToolChains/Darwin.cpp
1037 ↗(On Diff #176217)

Yes, since the runtime is a .a, the gcov-specific symbols aren't pulled in when clang-cov is enabled and vice versa.

ributzka accepted this revision.Nov 30 2018, 5:13 PM

LGTM

This revision is now accepted and ready to land.Nov 30 2018, 5:13 PM
marco-c accepted this revision.Dec 3 2018, 8:54 AM
Closed by commit rL348187: [gcov/Darwin] Ensure external symbols are exported when using an export list (authored by vedantk). · Explain WhyDec 3 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: llvm-commits, delcypher. · View Herald TranscriptDec 3 2018, 12:56 PM

Revision Contents
Changeset List

PathSize
cfe/
trunk/
include/
clang/
Driver/
3 lines
lib/
Driver/
12 lines
ToolChains/
14 lines
test/
Driver/
14 lines
compiler-rt/
trunk/
test/
profile/
8 lines

Diff 176458

View Options

cfe/trunk/include/clang/Driver/ToolChain.h

Loading...
View Options

cfe/trunk/lib/Driver/ToolChain.cpp

Loading...
View Options

cfe/trunk/lib/Driver/ToolChains/Darwin.cpp

Loading...
View Options

cfe/trunk/test/Driver/darwin-ld.c

Loading...
View Options

compiler-rt/trunk/test/profile/instrprof-darwin-exports.c

Loading...