Page MenuHomePhabricator

[ARM][AsmParser] Improve debug printing of parsed asm operands
ClosedPublic

Authored by olista01 on Nov 23 2018, 3:35 AM.

Details

Summary

In ARMOperand::print:

  • Print human-readable register names, instead of numbers.
  • Print the correct names for IT condition masks (these were in the wrong order before).
  • Print all parts of memory operands, not just the base register.

This makes the output of llvm-mc -show-inst-operands more readable.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Nov 23 2018, 3:35 AM

LGTM, do we have any tests for llvm-mc output?

This is only used for the -debug output (i.e. things inside the LLVM_DEBUG macro) and from within a debugger, I don't think we tend to test that.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 6:30 AM
This revision was automatically updated to reflect the committed changes.