This is an archive of the discontinued LLVM Phabricator instance.

[ASTMatchers] Add hasSideEffect() matcher.
ClosedPublic

Authored by courbet on Nov 22 2018, 2:41 AM.

Diff Detail

Event Timeline

courbet created this revision.Nov 22 2018, 2:41 AM
aaron.ballman accepted this revision.Nov 22 2018, 5:18 AM

LGTM aside from a minor commenting request.

include/clang/ASTMatchers/ASTMatchers.h
4121

side effects. -> side effects other than producing a value, such as a calling a function, throwing an exception, or reading a volatile variable.

This revision is now accepted and ready to land.Nov 22 2018, 5:18 AM
courbet updated this revision to Diff 175044.Nov 22 2018, 6:03 AM

address comment

courbet marked an inline comment as done.Nov 22 2018, 6:03 AM

Thanks.

This revision was automatically updated to reflect the committed changes.