This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Prevent parallel macs for unsigned values
ClosedPublic

Authored by samparker on Nov 21 2018, 5:20 AM.

Details

Summary

Both zext and sext are currently allowed during the search for narrow sequences and sexts operands are later added to the mac candidates. But operands of muls are also added, without checking whether they're sext or zext, which means we can generate a signed smlad when we shouldn't.

Diff Detail

Event Timeline

samparker created this revision.Nov 21 2018, 5:20 AM
This revision is now accepted and ready to land.Nov 23 2018, 2:05 AM
This revision was automatically updated to reflect the committed changes.