Page MenuHomePhabricator

[Docs] Documentation for the saturation addition and subtraction intrinsics
ClosedPublic

Authored by leonardchan on Nov 19 2018, 2:52 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

leonardchan created this revision.Nov 19 2018, 2:52 PM
bjope accepted this revision.Nov 20 2018, 2:34 AM

LGTM!

This revision is now accepted and ready to land.Nov 20 2018, 2:34 AM
bjope added inline comments.Nov 20 2018, 3:41 AM
llvm/docs/LangRef.rst
12579 ↗(On Diff #174690)

nit: As I also wrote in https://reviews.llvm.org/D54719 we will get a tiny problem when adding support for smul.fix.sat if we have one chapter called "Saturation Arithmetic Intrinsics" and one called "Fixed Point Arithmetic Intrinsics" in the LangRef. Maybe we can solve that by describing smul.fix.sat as a "Fixed Point Arithmetic Intrinsics" and maybe add a reference or something in this chapter. Or should all these saturation/fixedpoint intrinsics be in a common chapter?

leonardchan marked an inline comment as done.Nov 20 2018, 9:59 AM
leonardchan added inline comments.
llvm/docs/LangRef.rst
12579 ↗(On Diff #174690)

I'd be up for either. My initial plan was what your first suggestion was of putting it under the Fixed Point section with a reference or some mention to the Saturation section.

This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.