This is an archive of the discontinued LLVM Phabricator instance.

[ThinLTO] Allow importing of functions with var args
ClosedPublic

Authored by tejohnson on Nov 15 2018, 4:36 PM.

Details

Summary

Follow up to D54270, which allowed importing of var args functions
unless they called va_start. As pointed out in the post-commit comments
on that patch, the inliner can handle functions that call va_start in
certain situations as well. Go ahead and enable importing of all var
args functions. Measurements on a large binary show that this increases
imports and binary size by an insignificant amount.

Diff Detail

Event Timeline

tejohnson created this revision.Nov 15 2018, 4:36 PM
davidxl accepted this revision.Nov 30 2018, 2:51 PM

lgtm

This revision is now accepted and ready to land.Nov 30 2018, 2:51 PM
This revision was automatically updated to reflect the committed changes.