Page MenuHomePhabricator

Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON
AbandonedPublic

Authored by michaelplatings on Nov 15 2018, 10:15 AM.

Details

Reviewers
john.brawn
rnk
Summary

extract_symbols.py (introduced in D18826) expects all of its library arguments to be in the same directory - typically <config>/lib. DynamicLibraryLib.lib is instead to be found in lib/<config>.
This patch passes locations of libraries directly to extract_symbols.py so it doesn't need to guess.

Diff Detail

Repository
rL LLVM

Event Timeline

rnk accepted this revision.Nov 15 2018, 1:32 PM

lgtm

This revision is now accepted and ready to land.Nov 15 2018, 1:32 PM
michaelplatings abandoned this revision.Nov 19 2018, 7:42 AM

Thanks very much Reid for the speedy review. Unfortunately, due the the use of absolute paths, this patch causes long command lines to be generated which Visual Studio 2015 can't handle. So I have to abandon this patch.