Page MenuHomePhabricator

[DAGCombine] Fix non-deterministic debug output
ClosedPublic

Authored by samparker on Nov 15 2018, 1:00 AM.

Details

Summary

PR37970 reported non-deterministic debug output, this was caused by iterating through a set and not a a vector. Not sure how to test it, but I ran it locally 10 times with the provided reproducer and the issue seems to be resolved. @chh could you please confirm?

bugzilla: https://bugs.llvm.org/show_bug.cgi?id=37970

Diff Detail

Repository
rL LLVM

Event Timeline

samparker created this revision.Nov 15 2018, 1:00 AM
niravd accepted this revision.Nov 15 2018, 6:53 AM

LGTM.

This revision is now accepted and ready to land.Nov 15 2018, 6:53 AM
chh accepted this revision.Nov 15 2018, 9:59 AM

I probably won't have enough time to test this today.
This looks good to me. If you submit it now, I can cherry pick it and test later.
Thanks.

Closed by commit rL347037: [DAGCombine] Fix non-deterministic debug output (authored by sam_parker, committed by ). · Explain WhyNov 16 2018, 12:38 AM
This revision was automatically updated to reflect the committed changes.