Use forward declaration as the reviewer is in favor of #include and delete a redundant declaration of Function.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 24856 Build 24855: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for adding the include, I just saw the commit after I submitted the forward declaration.
If the forward declaration is sufficient (unfortunately the compiler I was using was clever enough to not require it...), I think it would be slightly better to remove the include. Both approaches LGTM, thank you very much!