This is an archive of the discontinued LLVM Phabricator instance.

[IPSCCP] Delete two forward declarations
ClosedPublic

Authored by MaskRay on Nov 11 2018, 1:48 PM.

Details

Summary

Use forward declaration as the reviewer is in favor of #include and delete a redundant declaration of Function.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Nov 11 2018, 1:48 PM
fhahn accepted this revision.Nov 11 2018, 2:36 PM

Thanks for adding the include, I just saw the commit after I submitted the forward declaration.

If the forward declaration is sufficient (unfortunately the compiler I was using was clever enough to not require it...), I think it would be slightly better to remove the include. Both approaches LGTM, thank you very much!

This revision is now accepted and ready to land.Nov 11 2018, 2:36 PM
MaskRay updated this revision to Diff 173595.Nov 11 2018, 3:19 PM
MaskRay edited the summary of this revision. (Show Details)

Delete include

This revision was automatically updated to reflect the committed changes.