This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Remove "default:" label in the switch covering all enum values.
ClosedPublic

Authored by Dor1s on Nov 9 2018, 8:46 AM.

Reviewers

Commits

Summary

Self-approval for this minor fix.

This revision is now accepted and ready to land.Nov 9 2018, 8:46 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

tools/

llvm-cov/

2 lines

Show First 20 Lines • Show All 1,033 Lines • ▼ Show 20 Lines	int CodeCoverageTool::doExport(int argc, const char **argv,
case CoverageViewOptions::OutputFormat::HTML:		case CoverageViewOptions::OutputFormat::HTML:
// Unreachable because we should have gracefully terminated with an error		// Unreachable because we should have gracefully terminated with an error
// above.		// above.
llvm_unreachable("Export in HTML is not supported!");		llvm_unreachable("Export in HTML is not supported!");
case CoverageViewOptions::OutputFormat::Lcov:		case CoverageViewOptions::OutputFormat::Lcov:
Exporter = llvm::make_unique<CoverageExporterLcov>(*Coverage.get(),		Exporter = llvm::make_unique<CoverageExporterLcov>(*Coverage.get(),
ViewOpts, outs());		ViewOpts, outs());
break;		break;
default:
llvm_unreachable("Unknown coverage output format!");
}		}

if (SourceFiles.empty())		if (SourceFiles.empty())
Exporter->renderRoot(IgnoreFilenameFilters);		Exporter->renderRoot(IgnoreFilenameFilters);
else		else
Exporter->renderRoot(SourceFiles);		Exporter->renderRoot(SourceFiles);

return 0;		return 0;
Show All 16 Lines