This is an archive of the discontinued LLVM Phabricator instance.

Differential D54299

[llvm-objdump] add more constraints for tests
ClosedPublic

Authored by Higuoxing on Nov 9 2018, 2:52 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG5014540a63af: [llvm-objdump] add more constraints for tests
rL346636: [llvm-objdump] add more constraints for tests

Diff Detail

Event Timeline

Higuoxing created this revision.Nov 9 2018, 2:52 AM
Higuoxing added a reviewer: jhenderson.
jhenderson accepted this revision.Nov 9 2018, 4:00 AM

LGTM.

This revision is now accepted and ready to land.Nov 9 2018, 4:00 AM
Higuoxing added a comment.Nov 9 2018, 4:03 AM

Sorry, my mind is absent when making those patches. Could you please commit this? Thanks a lot

MaskRay accepted this revision.Nov 12 2018, 12:10 AM
MaskRay added a subscriber: MaskRay.
MaskRay added inline comments.
test/tools/llvm-objdump/relocations-elf.test
2

Maybe just %t1 %t2 ?

Closed by commit rL346636: [llvm-objdump] add more constraints for tests (authored by MaskRay). · Explain WhyNov 12 2018, 12:12 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 12 2018, 12:12 AM

Revision Contents

PathSize
test/
tools/
llvm-objdump/
6 lines
6 lines

Diff 173292

test/tools/llvm-objdump/relocations-elf.test

# RUN: yaml2obj %s > %t # RUN: yaml2obj %s > %t
# RUN: llvm-objdump --reloc %t | FileCheck %s # RUN: llvm-objdump --reloc %t > %t.out1
MaskRayUnsubmitted
Not Done
ReplyInline Actions

Maybe just %t1 %t2 ?

MaskRay: Maybe just `%t1` `%t2` ?
# RUN: llvm-objdump -r %t | FileCheck %s # RUN: llvm-objdump -r %t > %t.out2
# RUN: cmp %t.out1 %t.out2
# RUN: FileCheck %s --input-file=%t.out1
# CHECK: RELOCATION RECORDS FOR [.rel.text]: # CHECK: RELOCATION RECORDS FOR [.rel.text]:
# CHECK: 0000000000000001 R_X86_64_32 glob1 # CHECK: 0000000000000001 R_X86_64_32 glob1
# CHECK: 0000000000000001 R_X86_64_32S glob2 # CHECK: 0000000000000001 R_X86_64_32S glob2
# CHECK: 0000000000000002 R_X86_64_64 loc1 # CHECK: 0000000000000002 R_X86_64_64 loc1
# CHECK: RELOCATION RECORDS FOR [.rela.text]: # CHECK: RELOCATION RECORDS FOR [.rela.text]:
# CHECK: 0000000000000001 R_X86_64_32 glob1+1 # CHECK: 0000000000000001 R_X86_64_32 glob1+1
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

test/tools/llvm-objdump/symbol-table-elf.test

# RUN: yaml2obj %s > %t # RUN: yaml2obj %s > %t
# RUN: llvm-objdump --syms %t | FileCheck %s # RUN: llvm-objdump --syms %t > %t.out1
# RUN: llvm-objdump -t %t | FileCheck %s # RUN: llvm-objdump -t %t > %t.out2
# RUN: cmp %t.out1 %t.out2
# RUN: FileCheck %s --input-file=%t.out1
# CHECK: SYMBOL TABLE: # CHECK: SYMBOL TABLE:
# CHECK-NEXT: 0000000000000000 *UND* 00000000 # CHECK-NEXT: 0000000000000000 *UND* 00000000
# CHECK-NEXT: 0000000000001004 l F .text 00000000 lfoo # CHECK-NEXT: 0000000000001004 l F .text 00000000 lfoo
# CHECK-NEXT: 0000000000001008 l .text 00000000 lbar # CHECK-NEXT: 0000000000001008 l .text 00000000 lbar
# CHECK-NEXT: 0000000000001004 g F .text 00000000 foo # CHECK-NEXT: 0000000000001004 g F .text 00000000 foo
# CHECK-NEXT: 0000000000001008 g .text 00000000 bar # CHECK-NEXT: 0000000000001008 g .text 00000000 bar
Show All 36 Lines