Page MenuHomePhabricator

[clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback
ClosedPublic

Authored by takuto.ikuta on Nov 9 2018, 1:49 AM.

Diff Detail

Repository
rC Clang

Event Timeline

takuto.ikuta created this revision.Nov 9 2018, 1:49 AM
takuto.ikuta retitled this revision from [clang-cl] Add warning for /Zc:dllexportInlines- with /fallback to [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback.Nov 9 2018, 1:53 AM
takuto.ikuta edited the summary of this revision. (Show Details)
takuto.ikuta added reviewers: hans, thakis.
takuto.ikuta added a subscriber: cfe-commits.
hans added inline comments.Nov 9 2018, 2:23 AM
clang/lib/Driver/ToolChains/Clang.cpp
5507 ↗(On Diff #173286)

I think the check should be with the code that handles /fallback, in visualstudio::Compiler::GetCommand, instead.

warn in GetCommand

takuto.ikuta marked an inline comment as done.Nov 9 2018, 4:57 AM

Thank you for review!

hans accepted this revision.Nov 9 2018, 4:59 AM

lgtm

This revision is now accepted and ready to land.Nov 9 2018, 4:59 AM
This revision was automatically updated to reflect the committed changes.