This is an archive of the discontinued LLVM Phabricator instance.

Differential D54147

[llvm-exegesis] Ignore X86 pseudo instructions.
ClosedPublic

Authored by courbet on Nov 6 2018, 4:52 AM.

Details

Reviewers
gchatelet
Commits
rG003e08ff28c2: [llvm-exegesis] Ignore X86 pseudo instructions.
rL346227: [llvm-exegesis] Ignore X86 pseudo instructions.
Summary

They do not lower to actual MCInsts and have no scheduling info.

Diff Detail

Event Timeline

courbet created this revision.Nov 6 2018, 4:52 AM
Herald added a subscriber: tschuett. · View Herald TranscriptNov 6 2018, 4:52 AM
Harbormaster completed remote builds in B24602: Diff 172744.Nov 6 2018, 4:53 AM
gchatelet added inline comments.Nov 6 2018, 5:01 AM
tools/llvm-exegesis/lib/X86/Target.cpp
78

Remove parenthesis

courbet updated this revision to Diff 172748.Nov 6 2018, 5:54 AM
courbet marked an inline comment as done.

address comment

Harbormaster completed remote builds in B24603: Diff 172748.Nov 6 2018, 5:55 AM
gchatelet accepted this revision.Nov 6 2018, 5:59 AM
This revision is now accepted and ready to land.Nov 6 2018, 5:59 AM
Closed by commit rL346227: [llvm-exegesis] Ignore X86 pseudo instructions. (authored by courbet). · Explain WhyNov 6 2018, 6:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-exegesis/
lib/
X86/
4 lines

Diff 172744

tools/llvm-exegesis/lib/X86/Target.cpp

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if (!MemoryOps.empty())
Result.push_back(MemoryOps); Result.push_back(MemoryOps);
Operands = Operands.drop_front(MemoryOps.size()); Operands = Operands.drop_front(MemoryOps.size());
} }
return Result; return Result;
} }
static llvm::Error IsInvalidOpcode(const Instruction &Instr) { static llvm::Error IsInvalidOpcode(const Instruction &Instr) {
const auto OpcodeName = Instr.Name; const auto OpcodeName = Instr.Name;
if ((Instr.Description->TSFlags & X86II::FormMask) == X86II::Pseudo) {
gchateletUnsubmitted
Done
ReplyInline Actions

Remove parenthesis

gchatelet: Remove parenthesis
return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: pseudo instruction");
}
if (OpcodeName.startswith("POPF") || OpcodeName.startswith("PUSHF") || if (OpcodeName.startswith("POPF") || OpcodeName.startswith("PUSHF") ||
OpcodeName.startswith("ADJCALLSTACK")) OpcodeName.startswith("ADJCALLSTACK"))
return llvm::make_error<BenchmarkFailure>( return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: Push/Pop/AdjCallStack"); "unsupported opcode: Push/Pop/AdjCallStack");
const bool ValidMemoryOperands = llvm::all_of( const bool ValidMemoryOperands = llvm::all_of(
getMemoryOperandRanges(Instr.Operands), MemoryOperandRange::isValid); getMemoryOperandRanges(Instr.Operands), MemoryOperandRange::isValid);
if (!ValidMemoryOperands) if (!ValidMemoryOperands)
return llvm::make_error<BenchmarkFailure>( return llvm::make_error<BenchmarkFailure>(
▲ Show 20 Lines • Show All 348 Lines • Show Last 20 Lines