This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Ignore X86 pseudo instructions.
ClosedPublic

Authored by courbet on Nov 6 2018, 4:52 AM.

Reviewers

Commits

Summary

They do not lower to actual MCInsts and have no scheduling info.

tools/llvm-exegesis/lib/X86/Target.cpp
78 ↗	(On Diff #172744)	Remove parenthesis

address comment

This revision is now accepted and ready to land.Nov 6 2018, 5:59 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

tools/

llvm-exegesis/

lib/

X86/

3 lines

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines	if (!MemoryOps.empty())
Result.push_back(MemoryOps);		Result.push_back(MemoryOps);
Operands = Operands.drop_front(MemoryOps.size());		Operands = Operands.drop_front(MemoryOps.size());
}		}
return Result;		return Result;
}		}

static llvm::Error IsInvalidOpcode(const Instruction &Instr) {		static llvm::Error IsInvalidOpcode(const Instruction &Instr) {
const auto OpcodeName = Instr.Name;		const auto OpcodeName = Instr.Name;
		if ((Instr.Description->TSFlags & X86II::FormMask) == X86II::Pseudo)
		return llvm::make_error<BenchmarkFailure>(
		"unsupported opcode: pseudo instruction");
if (OpcodeName.startswith("POPF") \|\| OpcodeName.startswith("PUSHF") \|\|		if (OpcodeName.startswith("POPF") \|\| OpcodeName.startswith("PUSHF") \|\|
OpcodeName.startswith("ADJCALLSTACK"))		OpcodeName.startswith("ADJCALLSTACK"))
return llvm::make_error<BenchmarkFailure>(		return llvm::make_error<BenchmarkFailure>(
"unsupported opcode: Push/Pop/AdjCallStack");		"unsupported opcode: Push/Pop/AdjCallStack");
const bool ValidMemoryOperands = llvm::all_of(		const bool ValidMemoryOperands = llvm::all_of(
getMemoryOperandRanges(Instr.Operands), MemoryOperandRange::isValid);		getMemoryOperandRanges(Instr.Operands), MemoryOperandRange::isValid);
if (!ValidMemoryOperands)		if (!ValidMemoryOperands)
return llvm::make_error<BenchmarkFailure>(		return llvm::make_error<BenchmarkFailure>(
▲ Show 20 Lines • Show All 348 Lines • Show Last 20 Lines