This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Correclty handle all X86 memory encoding formats.
ClosedPublic

Authored by courbet on Nov 6 2018, 2:52 AM.

Details

Summary

Add unit tests to check the support for each supported format to avoid
regressions such as the one in PR36906.

Diff Detail

Event Timeline

courbet created this revision.Nov 6 2018, 2:52 AM
courbet updated this revision to Diff 172731.Nov 6 2018, 2:53 AM

clang-format

gchatelet added inline comments.Nov 6 2018, 4:58 AM
tools/llvm-exegesis/lib/X86/Target.cpp
25–139

I don't understand this comment

113

I'd rather handle individual instructions rather than mayLoad/mayStore that may catch other instruction in the future.

courbet updated this revision to Diff 172753.Nov 6 2018, 6:19 AM
courbet marked 2 inline comments as done.

address comments

gchatelet accepted this revision.Nov 6 2018, 9:12 AM
This revision is now accepted and ready to land.Nov 6 2018, 9:12 AM
This revision was automatically updated to reflect the committed changes.