Page MenuHomePhabricator

[CodeGenCXX] XFAIL test for ASAN on Darwin.
ClosedPublic

Authored by vsapsai on Nov 5 2018, 5:48 PM.

Details

Summary

The test hits stack overflow trying to instantiate recursive templates.
It is observed with ASAN and not with a regular build because ASAN
increases stack frame size.

rdar://problem/45009892

Diff Detail

Repository
rC Clang

Event Timeline

vsapsai created this revision.Nov 5 2018, 5:48 PM
clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp
8 ↗(On Diff #172692)

Do we actually want UNSUPPORTED here? We don't want to fail if ASAN stack usage decreases?

vsapsai added inline comments.Nov 5 2018, 6:06 PM
clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp
8 ↗(On Diff #172692)

If ASAN stack usage decreases or template instantiation stack usage decreases, I'd like to know that and to remove XFAIL. My reason to prefer XFAIL over UNSUPPORTED is that currently the test fails due to specific implementation of Clang and ASAN, not due to conceptual incompatibility. But I don't have any evidence to show that my suggestion is actually better, so if my argument doesn't look convincing, most likely UNSUPPORTED would be better.

george.karpenkov accepted this revision.Nov 5 2018, 6:09 PM
george.karpenkov added inline comments.
clang/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp
8 ↗(On Diff #172692)

Either one works for me.

This revision is now accepted and ready to land.Nov 5 2018, 6:09 PM
This revision was automatically updated to reflect the committed changes.