Page MenuHomePhabricator

[fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds
ClosedPublic

Authored by TWeaver on Nov 2 2018, 8:20 AM.

Details

Summary

r345961 introduced a path check in .\tools\clang\tools\extra\test\clang-tidy\clang-tidy-run-with-database.cpp.

r345961 added a check line for a path that only handled / on unix machines and not \ on windows machines.

This patch handles both cases.

Diff Detail

Event Timeline

TWeaver created this revision.Nov 2 2018, 8:20 AM
sammccall accepted this revision.Nov 2 2018, 8:30 AM

Thank you!

{{.*}}not-exist also seems fine, up to you.

This revision is now accepted and ready to land.Nov 2 2018, 8:30 AM

I'm happy as is.

thanks for the review.

Oh, I don't have commit access, are you able to commit for me Sam?

Thanks

JonasToth closed this revision.Nov 2 2018, 9:38 AM
JonasToth added a subscriber: JonasToth.

Thank you very much for the patch!
Committed in r345995.