This is an archive of the discontinued LLVM Phabricator instance.

[XRay] Migrate FDR runtime to use refactored controller
ClosedPublic

Authored by dberris on Oct 29 2018, 9:19 PM.

Details

Summary

This change completes the refactoring of the FDR runtime to support the
following:

  • Generational buffer management.
  • Centralised and well-tested controller implementation.

In this change we've had to:

  • Greatly simplify the code in xray_fdr_logging.cc to only implement the glue code for calling into the controller.
  • Implement the custom and typed event logging functions in the FDRLogWriter.
  • Imbue the XRAY_NEVER_INSTRUMENT attribute onto all functions in the controller implementation.

Event Timeline

dberris created this revision.Oct 29 2018, 9:19 PM
This revision is now accepted and ready to land.Oct 29 2018, 9:29 PM
dberris updated this revision to Diff 171635.Oct 29 2018, 9:35 PM

Handling some more edge cases.

This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: Restricted Project. · View Herald TranscriptOct 29 2018, 9:38 PM