This is an archive of the discontinued LLVM Phabricator instance.

Differential D53827

[OpenMP] Fix condition.
ClosedPublic

Authored by gtbercea on Oct 29 2018, 12:31 PM.

Details

Reviewers
ABataev
caomhin
Commits
rG9d6341ff518c: [OpenMP] Fix condition.
rL345527: [OpenMP] Fix condition.
rC345527: [OpenMP] Fix condition.
Summary

Iteration variable must be strictly less than the number of iterations. This fixes a bug introduced by previous patch D53448.

Diff Detail

Repository
rC Clang

Event Timeline

gtbercea created this revision.Oct 29 2018, 12:31 PM
Herald added subscribers: cfe-commits, guansong. · View Herald TranscriptOct 29 2018, 12:31 PM
gtbercea added reviewers: ABataev, caomhin.Oct 29 2018, 12:32 PM
gtbercea updated this revision to Diff 171558.Oct 29 2018, 12:42 PM
Add tests.
Harbormaster completed remote builds in B24298: Diff 171558.Oct 29 2018, 12:42 PM
gtbercea retitled this revision from [OpenMP][NFC] Fix condition. to [OpenMP] Fix condition..Oct 29 2018, 12:43 PM
gtbercea edited the summary of this revision. (Show Details)
ABataev accepted this revision.Oct 29 2018, 12:43 PM

Rename, the patch, it is not an NFC.

This revision is now accepted and ready to land.Oct 29 2018, 12:43 PM
Closed by commit rC345527: [OpenMP] Fix condition. (authored by gbercea). · Explain WhyOct 29 2018, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Sema/
3 lines

Diff 171555

lib/Sema/SemaOpenMP.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,293 Lines • ▼ Show 20 Lines ExprResult Cond =
(isOpenMPWorksharingDirective(DKind) || (isOpenMPWorksharingDirective(DKind) ||
isOpenMPTaskLoopDirective(DKind) || isOpenMPDistributeDirective(DKind)) isOpenMPTaskLoopDirective(DKind) || isOpenMPDistributeDirective(DKind))
? SemaRef.BuildBinOp(CurScope, CondLoc, BO_LE, IV.get(), UB.get()) ? SemaRef.BuildBinOp(CurScope, CondLoc, BO_LE, IV.get(), UB.get())
: SemaRef.BuildBinOp(CurScope, CondLoc, BO_LT, IV.get(), : SemaRef.BuildBinOp(CurScope, CondLoc, BO_LT, IV.get(),
NumIterations.get()); NumIterations.get());
ExprResult CombDistCond; ExprResult CombDistCond;
if (isOpenMPLoopBoundSharingDirective(DKind)) { if (isOpenMPLoopBoundSharingDirective(DKind)) {
CombDistCond = CombDistCond =
SemaRef.BuildBinOp(CurScope, CondLoc, BO_LE, IV.get(), NumIterations.get()); SemaRef.BuildBinOp(
CurScope, CondLoc, BO_LT, IV.get(), NumIterations.get());
} }
ExprResult CombCond; ExprResult CombCond;
if (isOpenMPLoopBoundSharingDirective(DKind)) { if (isOpenMPLoopBoundSharingDirective(DKind)) {
CombCond = CombCond =
SemaRef.BuildBinOp(CurScope, CondLoc, BO_LE, IV.get(), CombUB.get()); SemaRef.BuildBinOp(CurScope, CondLoc, BO_LE, IV.get(), CombUB.get());
} }
// Loop increment (IV = IV + 1) // Loop increment (IV = IV + 1)
▲ Show 20 Lines • Show All 8,340 Lines • Show Last 20 Lines