This is an archive of the discontinued LLVM Phabricator instance.

[ubsan-minimal] update comments in CMakeLists.txt
ClosedPublic

Authored by sugak on Oct 29 2018, 12:27 PM.

Download Raw Diff

Details

Reviewers

eugenis
pcc

Commits

rG7c180fa9153e: [ubsan-minimal] update comments in CMakeLists.txt
rL345557: [ubsan-minimal] update comments in CMakeLists.txt
rCRT345557: [ubsan-minimal] update comments in CMakeLists.txt

Summary

Prepend minimal when UBsan is mentioned and delete a dead comment

Patch by Igor Sugak

Diff Detail

Repository: rCRT Compiler Runtime

Event Timeline

sugak created this revision.Oct 29 2018, 12:27 PM

Herald added subscribers: Restricted Project, mgorny. · View Herald TranscriptOct 29 2018, 12:27 PM

LGTM

This revision is now accepted and ready to land.Oct 29 2018, 12:42 PM

@eugenis, please push this for me!

vitalybuka edited the summary of this revision. (Show Details)Oct 29 2018, 6:07 PM

Closed by commit rCRT345557: [ubsan-minimal] update comments in CMakeLists.txt (authored by vitalybuka). · Explain WhyOct 29 2018, 6:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

ubsan_minimal/

CMakeLists.txt

8 lines

Diff 171620

lib/ubsan_minimal/CMakeLists.txt

	# Build for the undefined behavior sanitizer runtime support library.			# Build for the minimal undefined behavior sanitizer runtime support library.

	set(UBSAN_MINIMAL_SOURCES			set(UBSAN_MINIMAL_SOURCES
	ubsan_minimal_handlers.cc			ubsan_minimal_handlers.cc
	)			)

	include_directories(..)			include_directories(..)

	set(UBSAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})			set(UBSAN_CFLAGS ${SANITIZER_COMMON_CFLAGS})
	append_rtti_flag(OFF UBSAN_CFLAGS)			append_rtti_flag(OFF UBSAN_CFLAGS)

	set(UBSAN_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})			set(UBSAN_LINK_FLAGS ${SANITIZER_COMMON_LINK_FLAGS})

	set(UBSAN_DYNAMIC_LIBS ${SANITIZER_COMMON_LINK_LIBS})			set(UBSAN_DYNAMIC_LIBS ${SANITIZER_COMMON_LINK_LIBS})

	add_compiler_rt_component(ubsan-minimal)			add_compiler_rt_component(ubsan-minimal)

	# Common parts of UBSan runtime.			# Common parts of minimal UBSan runtime.
	add_compiler_rt_object_libraries(RTUbsan_minimal			add_compiler_rt_object_libraries(RTUbsan_minimal
	OS ${SANITIZER_COMMON_SUPPORTED_OS}			OS ${SANITIZER_COMMON_SUPPORTED_OS}
	ARCHS ${UBSAN_COMMON_SUPPORTED_ARCH}			ARCHS ${UBSAN_COMMON_SUPPORTED_ARCH}
	SOURCES ${UBSAN_MINIMAL_SOURCES} CFLAGS ${UBSAN_CFLAGS})			SOURCES ${UBSAN_MINIMAL_SOURCES} CFLAGS ${UBSAN_CFLAGS})


	if(COMPILER_RT_HAS_UBSAN_MINIMAL)			if(COMPILER_RT_HAS_UBSAN_MINIMAL)
	# Initializer of standalone UBSan runtime.			# Standalone minimal UBSan runtimes.

	# Standalone UBSan runtimes.
	add_compiler_rt_runtime(clang_rt.ubsan_minimal			add_compiler_rt_runtime(clang_rt.ubsan_minimal
	STATIC			STATIC
	OS ${SANITIZER_COMMON_SUPPORTED_OS}			OS ${SANITIZER_COMMON_SUPPORTED_OS}
	ARCHS ${UBSAN_SUPPORTED_ARCH}			ARCHS ${UBSAN_SUPPORTED_ARCH}
	OBJECT_LIBS RTUbsan_minimal			OBJECT_LIBS RTUbsan_minimal
	CFLAGS ${UBSAN_CFLAGS}			CFLAGS ${UBSAN_CFLAGS}
	PARENT_TARGET ubsan-minimal)			PARENT_TARGET ubsan-minimal)

	Show All 19 Lines