This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] [Windows] Emit unwind tables by default.
ClosedPublic

Authored by efriedma on Oct 23 2018, 3:29 PM.

Details

Summary

Unwind tables are necessary even in code that doesn't support exceptions. Among other things, the tables are used for setjmp(), and by debuggers.

Depends on D50288 so LLVM can emit the unwind tables.

Diff Detail

Repository
rC Clang

Event Timeline

efriedma created this revision.Oct 23 2018, 3:29 PM
rnk accepted this revision.Oct 23 2018, 3:33 PM

Yep, land it after the dependency.

lib/Driver/ToolChains/MSVC.cpp
724–725

Maybe update the comment to say that Windows has required unwind tables for every new architecture since x86_32, but clang only asks LLVM to emit unwind tables for the ones that LLVM supports.

This revision is now accepted and ready to land.Oct 23 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.