This is an archive of the discontinued LLVM Phabricator instance.

Fix warning: extra ‘;’ [-Wpedantic]
ClosedPublic

Authored by DennisL on Oct 23 2018, 6:06 AM.

Reviewers

• espindola
arichardson

Summary

fix a compiler warning

Repository

rLLD LLVM Linker

Build Status

Buildable 24069
Build 24068: arc lint + arc unit

Ah yes looks like I made a copy paste error when changing the lambda to a function and it compiled fine for me so I didn't notice.

This revision is now accepted and ready to land.Oct 23 2018, 11:06 AM

Closing it, was fixed in an unrelated revision.

Path

Size

ELF/

2 lines

Show First 20 Lines • Show All 173 Lines • ▼ Show 20 Lines	Symbol *Sym = Symtab->addDefined(Name, StOther, STT_NOTYPE, Val,
/Size=/0, Binding, Sec,		/Size=/0, Binding, Sec,
/File=/nullptr);		/File=/nullptr);
return cast<Defined>(Sym);		return cast<Defined>(Sym);
}		}

static Defined *addAbsolute(StringRef Name) {		static Defined *addAbsolute(StringRef Name) {
return cast<Defined>(Symtab->addDefined(Name, STV_HIDDEN, STT_NOTYPE, 0, 0,		return cast<Defined>(Symtab->addDefined(Name, STV_HIDDEN, STT_NOTYPE, 0, 0,
STB_GLOBAL, nullptr, nullptr));		STB_GLOBAL, nullptr, nullptr));
};		}

// The linker is expected to define some symbols depending on		// The linker is expected to define some symbols depending on
// the linking result. This function defines such symbols.		// the linking result. This function defines such symbols.
void elf::addReservedSymbols() {		void elf::addReservedSymbols() {
if (Config->EMachine == EM_MIPS) {		if (Config->EMachine == EM_MIPS) {
// Define _gp for MIPS. st_value of _gp symbol will be updated by Writer		// Define _gp for MIPS. st_value of _gp symbol will be updated by Writer
// so that it points to an absolute address which by default is relative		// so that it points to an absolute address which by default is relative
// to GOT. Default offset is 0x7ff0.		// to GOT. Default offset is 0x7ff0.
▲ Show 20 Lines • Show All 2,247 Lines • Show Last 20 Lines