This is an archive of the discontinued LLVM Phabricator instance.

Differential D53548

[analyzer] [NFC] Correct comment on RetainSummaryManager
ClosedPublic

Authored by george.karpenkov on Oct 22 2018, 6:20 PM.

Details

Reviewers
NoQ
dcoughlin
Commits
rGbc4e3238e234: [analyzer] [NFC] Correct comment on RetainSummaryManager
rC344992: [analyzer] [NFC] Correct comment on RetainSummaryManager
rL344992: [analyzer] [NFC] Correct comment on RetainSummaryManager

Diff Detail

Event Timeline

george.karpenkov created this revision.Oct 22 2018, 6:20 PM
Herald added subscribers: dkrupp, donat.nagy, Szelethus and 5 others. · View Herald TranscriptOct 22 2018, 6:20 PM
NoQ accepted this revision.Oct 22 2018, 6:20 PM

Just do it.

This revision is now accepted and ready to land.Oct 22 2018, 6:20 PM
Closed by commit rL344992: [analyzer] [NFC] Correct comment on RetainSummaryManager (authored by george.karpenkov). · Explain WhyOct 22 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 22 2018, 6:33 PM

Revision Contents

PathSize
clang/
include/
clang/
StaticAnalyzer/
Core/
4 lines

Diff 170552

clang/include/clang/StaticAnalyzer/Core/RetainSummaryManager.h

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Linesenum ArgEffect {
Dealloc, Dealloc,
/// The argument has its reference count decreased by 1. This is as /// The argument has its reference count decreased by 1. This is as
/// if CFRelease has been called on the argument. /// if CFRelease has been called on the argument.
DecRef, DecRef,
/// The argument has its reference count decreased by 1. This is as /// The argument has its reference count decreased by 1. This is as
/// if a -release message has been sent to the argument. This differs /// if a -release message has been sent to the argument. This differs
/// in behavior from DecRef when GC is enabled. /// in behavior from DecRef when ARC is enabled.
DecRefMsg, DecRefMsg,
/// The argument has its reference count decreased by 1 to model /// The argument has its reference count decreased by 1 to model
/// a transferred bridge cast under ARC. /// a transferred bridge cast under ARC.
DecRefBridgedTransferred, DecRefBridgedTransferred,
/// The argument has its reference count increased by 1. This is as /// The argument has its reference count increased by 1. This is as
/// if a -retain message has been sent to the argument. This differs /// if a -retain message has been sent to the argument. This differs
/// in behavior from IncRef when GC is enabled. /// in behavior from IncRef when ARC is enabled.
IncRefMsg, IncRefMsg,
/// The argument has its reference count increased by 1. This is as /// The argument has its reference count increased by 1. This is as
/// if CFRetain has been called on the argument. /// if CFRetain has been called on the argument.
IncRef, IncRef,
/// The argument acts as if has been passed to CFMakeCollectable, which /// The argument acts as if has been passed to CFMakeCollectable, which
/// transfers the object to the Garbage Collector under GC. /// transfers the object to the Garbage Collector under GC.
▲ Show 20 Lines • Show All 662 Lines • Show Last 20 Lines