This is an archive of the discontinued LLVM Phabricator instance.

Java annotation declaration being handled correctly
ClosedPublic

Authored by SamMaier on Oct 19 2018, 6:50 AM.

Details

Summary

Previously, Java annotation declarations (@interface AnnotationName) were being handled as ObjC interfaces. This caused the brace formatting to mess up, so that when you had a class with an interface defined in it, it would indent the final brace of the class.

It used to format this class like so:

class A {
  @interface B {}
  }

But will now just skip the @interface and format it like so:

class A {
  @interface B {}
}

Diff Detail

Repository
rC Clang

Event Timeline

SamMaier created this revision.Oct 19 2018, 6:50 AM
thakis accepted this revision.Oct 19 2018, 8:47 AM
thakis added a subscriber: thakis.

Thanks for the fix! Do you happen to know what had regressed this?

This revision is now accepted and ready to land.Oct 19 2018, 8:47 AM
This revision was automatically updated to reflect the committed changes.