This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Mark second-form X87 instructions as unsupported.
ClosedPublic

Authored by courbet on Oct 19 2018, 3:52 AM.

Reviewers

Commits

Summary

We only support the first form because we rely on information that is
only available there.

Repository

rL LLVM

Build Status

Buildable 23934
Build 23933: arc lint + arc unit

This revision is now accepted and ready to land.Oct 19 2018, 5:10 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

tools/

llvm-exegesis/

lib/

X86/

9 lines

	Show All 20 Lines

	namespace {			namespace {

	static llvm::Error IsInvalidOpcode(const Instruction &Instr) {			static llvm::Error IsInvalidOpcode(const Instruction &Instr) {
	const auto OpcodeName = Instr.Name;			const auto OpcodeName = Instr.Name;
	if (OpcodeName.startswith("POPF") \|\| OpcodeName.startswith("PUSHF") \|\|			if (OpcodeName.startswith("POPF") \|\| OpcodeName.startswith("PUSHF") \|\|
	OpcodeName.startswith("ADJCALLSTACK"))			OpcodeName.startswith("ADJCALLSTACK"))
	return llvm::make_error<BenchmarkFailure>(			return llvm::make_error<BenchmarkFailure>(
	"Unsupported opcode: Push/Pop/AdjCallStack");			"unsupported opcode: Push/Pop/AdjCallStack");
				// We do not handle second-form X87 instructions. We only handle first-form
				// ones (_Fp), see comment in X86InstrFPStack.td.
				for (const Operand &Op : Instr.Operands)
				if (Op.isReg() && Op.isExplicit() &&
				Op.getExplicitOperandInfo().RegClass == llvm::X86::RSTRegClassID)
				return llvm::make_error<BenchmarkFailure>(
				"unsupported second-form X87 instruction");
	return llvm::Error::success();			return llvm::Error::success();
	}			}

	static unsigned GetX86FPFlags(const Instruction &Instr) {			static unsigned GetX86FPFlags(const Instruction &Instr) {
	return Instr.Description->TSFlags & llvm::X86II::FPTypeMask;			return Instr.Description->TSFlags & llvm::X86II::FPTypeMask;
	}			}

	class X86LatencySnippetGenerator : public LatencySnippetGenerator {			class X86LatencySnippetGenerator : public LatencySnippetGenerator {
	▲ Show 20 Lines • Show All 336 Lines • Show Last 20 Lines